Re: SUBROUTINE DLNEXTRP in uv2dv_cfd

From: Dennis Shea <shea_at_nyahnyahspammersnyahnyah>
Date: Mon Apr 07 2014 - 08:09:19 MDT

Sorry. That should be :x... next release: 6.2.1 or 6.3.0

On 4/7/14, 7:54 AM, Dennis Shea wrote:
> This has been fixed and will be part of the next release: 6.1.2 or 6.3.0
>
> Thank You
> D
>
> On 4/3/14, 8:12 PM, Wei-Jen Tseng wrote:
>> Hi:
>>
>> I think I didn't show the error clearly in the previous mail.
>> There is a bug in the subroutine DLNEXTRP used in the function uv2dv_cfd.
>>
>> The number is the line number.
>>
>> code in NCL (6.2.0)
>> 391 + X(ML+1,NL).NE.XMSG) THEN
>> 400 + X(ML-1,NL).NE.XMSG) THEN
>> 409 + X(ML+1,NL).NE.XMSG) THEN
>> 410 X(ML,NL) = (2.D0*X(ML,NL-2)-X(ML,NL-2)+
>> 419 X(ML,NL) = (2.D0*X(ML,NL-2)-X(ML,NL-2)+
>>
>> corrected code may be ...
>> 391 + X(ML+2,NL).NE.XMSG) THEN
>> 400 + X(ML-2,NL).NE.XMSG) THEN
>> 409 + X(ML+2,NL).NE.XMSG) THEN
>> 410 X(ML,NL) = (2.D0*X(ML,NL-1)-X(ML,NL-2)+
>> 419 X(ML,NL) = (2.D0*X(ML,NL-1)-X(ML,NL-2)+
>>
>> best regards,
>> Wei-Jen
>>
>>
>> 2013-04-30 7:23 GMT+08:00 Dennis Shea <shea@ucar.edu>:
>>
>>> Hello Wei-Jen
>>>
>>> You are correct. The underlying fortran code had an error.
>>> IF (X(ML,NL).EQ.XMSG) THEN
>>>
>>> :
>>> IF (NL.EQ.NLAT .AND. ML.EQ.MLON) THEN
>>> :
>>> + X(ML-1,NL).NE.XMSG) THEN
>>>
>>> should be
>>>
>>> + X(ML-2,NL).NE.XMSG) THEN
>>>
>>> This has been corrected and a fix has been checked in.
>>>
>>> Thank You
>>
>>
> _______________________________________________
> ncl-talk mailing list
> List instructions, subscriber options, unsubscribe:
> http://mailman.ucar.edu/mailman/listinfo/ncl-talk
>
_______________________________________________
ncl-talk mailing list
List instructions, subscriber options, unsubscribe:
http://mailman.ucar.edu/mailman/listinfo/ncl-talk
Received on Mon Apr 07 08:09:27 2014

This archive was generated by hypermail 2.1.8 : Tue Apr 15 2014 - 10:45:19 MDT