Re: SUBROUTINE DLNEXTRP in uv2dv_cfd

From: Wei-Jen Tseng <tseng.weijen_at_nyahnyahspammersnyahnyah>
Date: Thu Apr 03 2014 - 20:12:07 MDT

Hi:

I think I didn't show the error clearly in the previous mail.
There is a bug in the subroutine DLNEXTRP used in the function uv2dv_cfd.

The number is the line number.

code in NCL (6.2.0)
391 + X(ML+1,NL).NE.XMSG) THEN
400 + X(ML-1,NL).NE.XMSG) THEN
409 + X(ML+1,NL).NE.XMSG) THEN
410 X(ML,NL) = (2.D0*X(ML,NL-2)-X(ML,NL-2)+
419 X(ML,NL) = (2.D0*X(ML,NL-2)-X(ML,NL-2)+

corrected code may be ...
391 + X(ML+2,NL).NE.XMSG) THEN
400 + X(ML-2,NL).NE.XMSG) THEN
409 + X(ML+2,NL).NE.XMSG) THEN
410 X(ML,NL) = (2.D0*X(ML,NL-1)-X(ML,NL-2)+
419 X(ML,NL) = (2.D0*X(ML,NL-1)-X(ML,NL-2)+

best regards,
Wei-Jen

2013-04-30 7:23 GMT+08:00 Dennis Shea <shea@ucar.edu>:

> Hello Wei-Jen
>
> You are correct. The underlying fortran code had an error.
> IF (X(ML,NL).EQ.XMSG) THEN
>
> :
> IF (NL.EQ.NLAT .AND. ML.EQ.MLON) THEN
> :
> + X(ML-1,NL).NE.XMSG) THEN
>
> should be
>
> + X(ML-2,NL).NE.XMSG) THEN
>
> This has been corrected and a fix has been checked in.
>
> Thank You

-- 
Wei-Jen Tseng
Department of Atmosphere Sciences, National Taiwan University
Email: tseng.weijen@gmail.com

_______________________________________________
ncl-talk mailing list
List instructions, subscriber options, unsubscribe:
http://mailman.ucar.edu/mailman/listinfo/ncl-talk
Received on Thu Apr 03 20:12:25 2014

This archive was generated by hypermail 2.1.8 : Tue Apr 15 2014 - 10:45:19 MDT