Re: Build failure of 6.2.0 without EOS

Orion,

Thanks for report this.

We actually found this error yesterday (somehow it did not happen before).
We just need to change "FAIL" to "FAILED".
The change is already in our trunk version (unfortunately, we could not put it into 6.2.0),
and certainly will be in the next release.

Again, thanks for report this.

Wei

On Apr 4, 2014, at 2:39 PM, Orion Poplawski <orion@cora.nwra.com> wrote:

> The Fedora ncl build is currently done without EOS support. I suspect that as a result we get the following error:
>
> NclNewHDF5.c:2552:20: error: 'FAIL' undeclared (first use in this function)
> if (f_space == FAIL)
>
> It appears that FAIL is defined in the EOS headers (I see it used in other NCL EOS code). Changing to < 0 is probably more correct as the HDF5 description states:
>
> Returns:
> Returns a dataspace identifier if successful; otherwise returns a negative value.
>
> (Interesting that most of your checks for negative values are of the form:
> (0 > ret_value), haven't seen that before).
>
> Patch is attached.
>
> - Orion
>
> --
> Orion Poplawski
> Technical Manager 303-415-9701 x222
> NWRA, Boulder/CoRA Office FAX: 303-415-9702
> 3380 Mitchell Lane orion@nwra.com
> Boulder, CO 80301 http://www.nwra.com
> <ncl-hdf5.patch>_______________________________________________
> ncl-install mailing list
> List instructions, subscriber options, unsubscribe:
> http://mailman.ucar.edu/mailman/listinfo/ncl-install

_______________________________________________
ncl-install mailing list
List instructions, subscriber options, unsubscribe:
http://mailman.ucar.edu/mailman/listinfo/ncl-install
Received on Fri Apr 04 14:43:44 2014