Build failure of 6.2.0 without EOS

From: Orion Poplawski <orion_at_nyahnyahspammersnyahnyah>
Date: Fri Apr 04 2014 - 14:39:43 MDT

The Fedora ncl build is currently done without EOS support. I suspect that as
a result we get the following error:

NclNewHDF5.c:2552:20: error: 'FAIL' undeclared (first use in this function)
      if (f_space == FAIL)

It appears that FAIL is defined in the EOS headers (I see it used in other NCL
EOS code). Changing to < 0 is probably more correct as the HDF5 description
states:

Returns:
     Returns a dataspace identifier if successful; otherwise returns a
negative value.

(Interesting that most of your checks for negative values are of the form:
   (0 > ret_value), haven't seen that before).

Patch is attached.

- Orion

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com


_______________________________________________
ncl-install mailing list
List instructions, subscriber options, unsubscribe:
http://mailman.ucar.edu/mailman/listinfo/ncl-install

Received on Fri Apr 04 14:39:51 2014

This archive was generated by hypermail 2.1.8 : Wed Apr 16 2014 - 09:15:26 MDT