ncl-6.1.2 bug report #2

Hello there,

I also ran the static analyser "cppcheck" over the source code of ncl-6.1.2

It said

[xresources.c:298]: (error) Pointer to local array variable returned.

Looks like broken code to me.

I also tried compiling ncl with a recent snapshot of the gcc compiler.
It said

ictrans_mem.c:91:22: warning: attempt to free a non-heap object 'Args' [-Wfree-nonheap-object]

Source code is

    if (Args[unit]) free((Voidptr) Args);

Maybe

    if (Args[unit]) free(Args[unit]);

was intended.

Regards

David Binderman
_______________________________________________
ncl-talk mailing list
List instructions, subscriber options, unsubscribe:
http://mailman.ucar.edu/mailman/listinfo/ncl-talk
Received on Wed May 15 10:39:16 2013