ncl-6.1.2 bug report #1

Hello there,

I just compiled ncl-6.1.2 with the compiler flag -D_FORTIFY_SOURCE=2

It said

1.

In function 'strcpy',
    inlined from 'PIX_OpenWorkstation' at pixcontrol.c:738:16:
/usr/include/bits/string3.h:104:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer [enabled by default]

Source code is

        xi->filename = malloc(5 * sizeof(char));
            strcpy(xi->filename,"gmeta");

Suggest change 5 to 6.

2.

In function 'sprintf',
    inlined from 'InsertLogo' at ncarlogo2ps.c:306:10:
/usr/include/bits/stdio2.h:33:3: warning: call to __builtin___sprintf_chk will always overflow destination buffer [enabled by default]

Source code is

  sprintf(scale+22,"scale\n");

Suggest increase 28 in call to calloc to 29.

3.

Further duplicates in ncarlogo2ps.c at lines 309 and 311.

Regards

David Binderman
_______________________________________________
ncl-talk mailing list
List instructions, subscriber options, unsubscribe:
http://mailman.ucar.edu/mailman/listinfo/ncl-talk
Received on Wed May 15 10:30:57 2013